Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements for the manager #655

Merged
merged 1 commit into from
Jan 14, 2021
Merged

Improvements for the manager #655

merged 1 commit into from
Jan 14, 2021

Conversation

Senyoret1
Copy link
Contributor

Did you run make format && make check?
The go code was not changed. npm run lint and npm run build were used.

Changes:

  • Improvements were made to how the visor list data is managed, to avoid unnecessary loading times.
  • A new start page, for redirecting the user to the real appropriate initial page and avoid some weird behaviors, was added.
  • A new delayed data refresh procedure was added to the app list, because some changes may take more time than expedted and that made the app list to remain outdated after making some changes.
  • Some calls to data clearing procedures the were not being called were added.

How to test this PR:

  • When entering to the visor details page and returning to the visor list, the visor list should be displayed inmediatelly, without the big loading animation. This happened mainly when the app settings were changad to update the data automatically every 3 seconds.
  • If the auth options are disabled, opening the root URL of the app should redirect to the visor list page, instead of opening the loging page and then be redirected to the visor list.
  • Alter starting or stopping an app, its state should be updated in the app list. The faulty cases were not very easy to reproduce, but some times starting the VPN server app made the problem to appear.

@jdknives
Copy link
Member

Works very well. Good job!

@jdknives jdknives merged commit f2cc79c into skycoin:develop Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants