Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for the modal windows bottom margin #698

Merged
merged 1 commit into from
Mar 13, 2021
Merged

Fixes for the modal windows bottom margin #698

merged 1 commit into from
Mar 13, 2021

Conversation

Senyoret1
Copy link
Contributor

Did you run make format && make check?
The go code was not changed. npm run lint and npm run build were used.

Changes:

  • Previously, if a modal window with a form and a button at the bottom needed scroll bars, the bottom marging was ignored:
    m
    This PR solves that problem.

How to test this PR:
Open a modal window with a form and a button at the bottom (add transport, edit label, VPN server config, etc.) and resize the browser so that the modal window needs vertical scroll bars. The margin at the bottom should be present.

Copy link
Member

@jdknives jdknives left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well.

@jdknives jdknives merged commit 756e74b into skycoin:develop Mar 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants