-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display local IP #716
Display local IP #716
Conversation
…returning bytes
- `DefaultNetworkInterface`, `LocalNetworkInterfaceIPs`, `NetworkInterfaceIPs` were moved from `vpn` to `util/netutil`; - `DefaultNetworkInterface` was implemented for MacOS.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well on Mac.
Worked well in my test using Linux. However, I’m not sure if it will work well with #699 and the PR it depends on. Also, quick question: if it works only in Mac and Linux, what is the expected content of the |
@Senyoret1 previously it couldn't be built on Windows. but I fixed it, now it will return empty string for Win |
Did you run
make format && make check
?Yes
Fixes #389
Works only on Linux and MacOS systems
This PR also contains all the commits from #685 . So if this gets merged, #685 may be closed for good.
Changes:
DefaultNetworkInterface
,LocalNetworkInterfaceIPs
,NetworkInterfaceIPs
were moved fromvpn
toutil/netutil
;DefaultNetworkInterface
was implemented for MacOS;local_ip
field was added to the response from `/api/visors/{pk}.How to test this PR:
/api/visors/{pk}
. It should containlocal_ip
field with the corresponding value for you default network interface IP