Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show the IP in the UI #721

Merged
merged 1 commit into from
Mar 24, 2021
Merged

Show the IP in the UI #721

merged 1 commit into from
Mar 24, 2021

Conversation

Senyoret1
Copy link
Contributor

Did you run make format && make check?
The go code was not changed. npm run lint and npm run build were used.

Fixes #719

Changes:

  • The visor IP is now used as the default label for visors without label.
  • The visor details page now shows the visor IP.
  • Now the apps list shows a link for opening the UI of the Skychat app in a new tab. For building the URL, the code uses the visor IP and tries to get the port from the app arguments, but if the port is not there, 8001 is used as the default port.

How to test this PR:
To see the default label, just open the visor list, the IP should be shown as the label of all visors without a label set (previously, the default label was just a part of the public key). For checking the IP of a visor, open the visor details page, the IP should be shown in the right bar. For opening the Skywallet UI, open the app list of a visor and press the link button at the right of the Skychat row.

@jdknives
Copy link
Member

This works well. Will merge. Need to revisit the implementation on the backend though for MacOS.

@jdknives jdknives merged commit 2cd440a into skycoin:develop Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants