New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a problem with the time since last update #742

Merged

jdknives merged 1 commit into skycoin:develop from Senyoret1:fix-time

Apr 23, 2021

Contributor

Senyoret1 commented Apr 23, 2021

Did you run make format && make check?
The go code was not changed. npm run lint and npm run build were used.

Changes:

Solves a problem which made the visor list show that the data was updated more than 2000 weeks ago:

The problem happened if the user tried to refresh the data by pressing the refresh button but the procedure failed.

How to test this PR:

Open the Skywire manager and enter to the visor list.
Use the web developer tools to block the network connection and immediately after that press the refresh button at the top-right part of the visor list page.You should see an error message indicating that the data was not updated.
Use the web developer tools to allow network access again. That data should be updated automatically after a moment.

Those steps caused the error before this PR.


          Fix a problem with the time since last update

jdknives approved these changes

View reviewed changes

jdknives merged commit 961db29 into skycoin:develop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet