-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solve nil pointer derefrence #750
Conversation
I have managed to fix that issue by sending empty fields. But I think that's unnecessary data, and would be better if there is a fix from the UI side. Having said that, it might not make a lot of difference and we can keep using this fix. |
@i-hate-nicknames can we use extraSummaryResp with |
@ersonp @i-hate-nicknames just a general comment from my side: While reviewing the fix from Erson, I thought that the naming for the various summaries could be clearer. Currently it looks to me like there are multiple summaries which leads us to weird constructs such as |
Yes, feels like it definitely needs some refactoring. There are multiple levels of extra that seems to have been added over time. Visor has summary and extra summary, and hypervisor has his own extra summary, plus response wrappers around visor summaries:
I would propose:
|
Did you run
make format && make check
?yes
Fixes #740
Changes:
Summary
struct insideExtraSummary
How to test this PR: