-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Summaries #759
Refactor Summaries #759
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to me like TCP address is not actually completely removed. If it is, then we can probably get rid of the whole network stats structure because
TCPAddr
is goneOnline
field is not actually filled by visor iirc so it does not need to be part of the summary.
|
This reverts commit de3dd9e.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working well, just 2 things:
- With the changes made, some parts of the UI code are no longer needed, but I checked and added them to a list, so I can make the changes after this PR is merged, to avoid delays with this one.
- I'm not a fan of updating the compiled UI files in PRs that were made for adding other changes, but if nobody else has problems with this, there is no problem.
Did you run
make format && make check
?yes
Fixes #757
Changes:
Summary
toOverview
andExtraSummary
toSummary
.NetworkStats
.extraSummaryWithDmsgResp
and updated the newSummary
accordingly.getVisorsExtraSummary
togetAllVisorsSummary
.TCPAddr
field frommakeSummaryResp
How to test this PR:
make build-ui; make move-built-frontend ; make build; make install