Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update service discovery update interval #797

Merged
merged 2 commits into from
Jun 7, 2021
Merged

Update service discovery update interval #797

merged 2 commits into from
Jun 7, 2021

Conversation

ersonp
Copy link
Contributor

@ersonp ersonp commented Jun 7, 2021

Did you run make format && make check?
yes
Fixes #417

Changes:

  • Updated Service Discovery interval from 30 s to 60 s.

How to test this PR:

  1. Change log_level to debug in visor config.
  2. Run ./skywire-cli visor gen-config -r
  3. Run ./skywire-visor skywire-config
  4. Check if app_discovery updates it's entries every 60 seconds or not.

The heartbeat rate of the uptime-tracker is already 60 seconds.

@jdknives jdknives merged commit ed94dcc into skycoin:develop Jun 7, 2021
Copy link
Member

@jdknives jdknives left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ersonp ersonp deleted the update-disc-interval branch April 11, 2022 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants