Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix data race in hypervisor #809

Merged
merged 1 commit into from
Jun 11, 2021
Merged

Fix data race in hypervisor #809

merged 1 commit into from
Jun 11, 2021

Conversation

ersonp
Copy link
Contributor

@ersonp ersonp commented Jun 10, 2021

Did you run make format && make check?
Yes

Fixes #803

Changes:

  • Added lock to hv.selfConn usage

How to test this PR:

  1. Run go build -race -o ./skywire-visor ./cmd/skywire-visor
  2. Run sudo ./skywire-visor skywire-config.json
  3. Open UI in browser http://localhost:8000/
  4. Go to visor details
  5. No error should be seen

@i-hate-nicknames
Copy link
Contributor

Looks good!

@jdknives jdknives merged commit e1ab759 into skycoin:develop Jun 11, 2021
@ersonp ersonp deleted the fix-datarace branch April 11, 2022 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdknives jdknives jdknives approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ersonp @i-hate-nicknames @jdknives