Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change perm of pid and logstore #810

Merged
merged 3 commits into from
Jun 10, 2021
Merged

Change perm of pid and logstore #810

merged 3 commits into from
Jun 10, 2021

Conversation

ersonp
Copy link
Contributor

@ersonp ersonp commented Jun 10, 2021 •
edited
Loading

Did you run make format && make check?
Yes

Fixes #808

Changes:

  • Changed ownerRW to ownerRWOtherRW
  • Changed file perm of pidFile, ownerRWOtherRW and NewBBoltLogStore from 600 to 606
  • Added make run
  • Combined make move-built-frontend and make build-ui into make build-ui.

How to test this PR:

  1. Delete local folder sudo rm -rf local/
  2. Run visor sudo ./skywire-visor skywire-config.json
  3. Ctrl+C
  4. Run ./ci_scripts/docker-push.sh -t $(git rev-parse --abbrev HEAD) -b
  5. No file permission error should be observed

jdknives
jdknives reviewed Jun 10, 2021
View reviewed changes
Copy link
Member

@jdknives jdknives left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good moslty.

pkg/util/pathutil/util.go Outdated Show resolved Hide resolved
@ersonp ersonp changed the title Chenge perm of pid and logstore Change perm of pid and logstore Jun 10, 2021
@jdknives jdknives merged commit b74a76f into skycoin:develop Jun 10, 2021
@ersonp ersonp deleted the pid-perm branch April 11, 2022 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdknives jdknives jdknives approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ersonp @jdknives