Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complete Visor Logs #820

Merged
merged 2 commits into from
Jun 24, 2021
Merged

Complete Visor Logs #820

merged 2 commits into from
Jun 24, 2021

Conversation

mrpalide
Copy link
Contributor

Did you run make format && make check?

Fixes #795

Changes:

  • The visor logs API returns logs that stored in visor store, so we change inner loggers in some functions to visor loggers to store those logs.

How to test this PR:

@CLAassistant
Copy link

CLAassistant commented Jun 23, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

jdknives
jdknives reviewed Jun 23, 2021
View reviewed changes
Copy link
Member

@jdknives jdknives left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work fairly well. I think the logs are complete.

@alexadhy
Copy link
Contributor

LGTM,no issue here.

@mrpalide mrpalide changed the title [WIP] Complete Visor Logs Complete Visor Logs Jun 24, 2021
@ersonp
Copy link
Contributor

ersonp commented Jun 24, 2021

Looks good to me.

@jdknives jdknives merged commit aac7d7e into skycoin:develop Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdknives jdknives jdknives left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mrpalide @CLAassistant @alexadhy @ersonp @jdknives