Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Skybian build version to summary of visor API and debugging #849

Merged
merged 1 commit into from
Aug 4, 2021
Merged

add Skybian build version to summary of visor API and debugging #849

merged 1 commit into from
Aug 4, 2021

Conversation

mrpalide
Copy link
Contributor

Did you run make format && make check? Yes

Fixes: Related to issue 99 in Skybian

Changes:

How to test this PR:
You should build a new image from skybian, or add Environment=SKYBIAN_BUILD_VERSION=vX.Y.Z on skywire-visor.service file.

@CLAassistant
Copy link

CLAassistant commented Jul 22, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@Senyoret1 Senyoret1 mentioned this pull request Jul 26, 2021
Merged
ersonp
ersonp approved these changes Aug 4, 2021
View reviewed changes
Copy link
Contributor

@ersonp ersonp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as inteneded

@jdknives jdknives merged commit a39d0e0 into skycoin:develop Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ersonp ersonp ersonp approved these changes

@jdknives jdknives jdknives approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mrpalide @CLAassistant @jdknives @ersonp