Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix data race #850

Merged
merged 1 commit into from
Jul 28, 2021
Merged

Fix data race #850

merged 1 commit into from
Jul 28, 2021

Conversation

ersonp
Copy link
Contributor

@ersonp ersonp commented Jul 22, 2021

Did you run make format && make check?
yes

Fixes #845

Changes:

  • Added lock

How to test this PR:

  1. Build skysocks with -race flag
  2. Start a visor and stop it
  3. No datarace should be seen

@jdknives jdknives merged commit 0a95f20 into skycoin:develop Jul 28, 2021
@ersonp ersonp deleted the fix-skysocks branch April 11, 2022 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ersonp @jdknives