Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/refactor init #858

Merged
merged 2 commits into from
Aug 11, 2021
Merged

Feature/refactor init #858

merged 2 commits into from
Aug 11, 2021

Conversation

i-hate-nicknames
Copy link
Contributor

Did you run make format && make check?

Fixes #785

Changes:

  • Init logic refactored

How to test this PR:
Run visor and make sure all functionality is preserved

ersonp
ersonp approved these changes Aug 9, 2021
View reviewed changes
Copy link
Contributor

@ersonp ersonp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Works without any error.

alexadhy
alexadhy approved these changes Aug 9, 2021
View reviewed changes
Copy link
Contributor

@alexadhy alexadhy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works without a hitch for me

@jdknives jdknives merged commit db82618 into skycoin:develop Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexadhy alexadhy alexadhy approved these changes

@ersonp ersonp ersonp approved these changes

@jdknives jdknives jdknives approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@i-hate-nicknames @jdknives @ersonp @alexadhy