Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Persistent transports cancel issue #874

Merged
merged 3 commits into from
Sep 8, 2021
Merged

Fix Persistent transports cancel issue #874

merged 3 commits into from
Sep 8, 2021
+40 −17

Conversation

ersonp
Copy link
Contributor

@ersonp ersonp commented Sep 8, 2021

Did you run make format && make check?

Fixes #

Changes:

  • Fixed GetPersistentTransports and UpdatePersistentTransports comments in visorconfig
  • Fixed cancel persistent transport issue

How to test this PR:

  1. Build with UI make build-ui; make move-built-frontend ; make build; make install
  2. Run visor ./skywire-visor skywire-config.json
  3. Add a persistent transport that is not working. Check logs for connection reattempts.
  4. Click on the star on the greyed-out transport to remove it from persistent transports.
  5. Check if the reconnect loop stops.

mrpalide
mrpalide approved these changes Sep 8, 2021
View reviewed changes
Copy link
Contributor

@mrpalide mrpalide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, and functionality work as well as possible.

@jdknives jdknives merged commit ee8884d into skycoin:develop Sep 8, 2021
@ersonp ersonp deleted the fix/persistent-transports branch April 11, 2022 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrpalide mrpalide mrpalide approved these changes

@jdknives jdknives jdknives approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ersonp @jdknives @mrpalide