-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dmsg delete entry on shutdown #883
Conversation
This reverts commit 4508a11.
@jdknives I was looking at the code and it seems like we need a nil check for TransportSetup module since |
We need to define a PubKey for that service before we push out the release so it is not null by default. If it is though by user intervention, we should not initialize the module. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just proper error checks thing for consistency
Did you run
make format && make check
?Fixes #
Changes:
dmsgC.Close()
ininitDmsg
in modulesgo dmsgC.Serve(ctx)
fromNewTransportListener
as it was being called twice.How to test this PR:
replace github.com/skycoin/dmsg => ../dmsg
in go.mod .make dep
skywire-services
makelog:"debug"
inintegration/generic/visorA.json
skywire-services
Ctrl+C
This can be tested without integration env on
http://dmsg-discovery.myownsky.xyz
.