Remove heartbeat | Add Deregister

[mrpalide]

Did you run make format && make check? Yes

Fixes Skywire Service #447

Changes:

• remove updater loop
• change Delete entry to Deregister
• add Deregister on client side (skywire) stop app process and visor shutdown process.

How to test this PR:

• Run visor with vpn-server true, then stop it by hypervisor UI or shutdown visor from CLI. Then check sd.skycoin.com/api/services?type=vpn for related PK.

[jdknives]

It seems this PR is unfinished. There are a few questions regarding the changes you made but more importantly there seem to be a few things that have not been tackled at all yet. We have an updating interval in the serviceupdater struct defined despite us getting rid of the loop using that value.

I also wonder whether we still need the waitgroup and the cancelfunc given that we get rid of the update loop which we originally used it for.

[ersonp]

Besides some naming conventions for functions, everything looks good. Everything else is working as expected. I tested by registering vpn-server and public visor. vpn-server entry is deleted on stopping the app as well as with the shutdown logic. public visor entry is deleted with the shutdown logic.

[jdknives]

Besides some naming conventions for functions, everything looks good. Everything else is working as expected. I tested by registering vpn-server and public visor. vpn-server entry is deleted on stopping the app as well as with the shutdown logic. public visor entry is deleted with the shutdown logic.

Fair point. We can call it entry on the service side as well. We do that in the dmsg-discovery and transport-discovery as well.

[ersonp]

Everything looks good besides the config, that I have mentioned above. I have tested visor, vpn and skysocks registration and deletion and it works as intended.

[ersonp]

Everything looks good.