Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/vpn panic #887

Merged
merged 3 commits into from
Sep 20, 2021
Merged

Fix/vpn panic #887

merged 3 commits into from
Sep 20, 2021

Conversation

ersonp
Copy link
Contributor

@ersonp ersonp commented Sep 17, 2021

Did you run make format && make check?

Fixes #885

Changes:

  • Moved remoteClosed chan check from select to if.

How to test this PR:

  1. Use the following services
dmsg_discovery: http://dmsg.discovery.skywire.cc
transport_discovery: http://transportt.skywire.cc
address_resolver: http://boom.skywire.cc
setup_node: 026c2a3e92d6253c5abd71a42628db6fca9dd9aa037ab6f4e3a31108558dfd87cf
route_finder: http://rft.skywire.cc
uptime_tracker: http://uptime.tracker.skywire.cc
service_discovery: http://sdt.skywire.cc
  1. Run visorA with a vpn-server
  2. On visorB make a dmsg transport to visorA. Will have to make one via cli or perisitent_transports as UI needs to be rebuilt
  • cli
./skywire-cli visor add-tp <visor-a-pk> --type dmsg 
  • perisitent_transports in config add
"persistent_transports": [
		{
			"pk": "<visor-a-pk>",
			"type": "dmsg"
		}
],
  1. Add pk of visorA to VPN client and start it.
  2. Start a video in the background and stop the VPN client.
  3. There should be no panic.

pkg/router/route_group.go Outdated Show resolved Hide resolved
@jdknives jdknives merged commit ea3bbc4 into skycoin:develop Sep 20, 2021
@ersonp ersonp deleted the fix/vpn-panic branch April 11, 2022 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants