Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove stcpr heartbeat #888

Merged
merged 13 commits into from
Sep 27, 2021
Merged

Remove stcpr heartbeat #888

merged 13 commits into from
Sep 27, 2021

Conversation

ersonp
Copy link
Contributor

@ersonp ersonp commented Sep 20, 2021 •
edited
Loading

Did you run make format && make check?
yes

Fixes #448-skywire-services

Changes:

  • Removed STCPR heartbeat
  • Added STCPR unbind
  • Added SUDPH unbind
  • Updated Test Setup Node PK
  • Fixed shutdown log of readSUDPHMessages
  • Added log on successful sudph bind

How to test this PR:
Instructions given here

@ersonp ersonp marked this pull request as ready for review September 21, 2021 19:08
mrpalide
mrpalide reviewed Sep 22, 2021
View reviewed changes
Copy link
Contributor

@mrpalide mrpalide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, I should check #415 for functionality.

@jdknives jdknives merged commit 654f752 into skycoin:develop Sep 27, 2021
@ersonp ersonp deleted the rm-ar-heartbeat branch April 11, 2022 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrpalide mrpalide mrpalide left review comments

@jdknives jdknives jdknives left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ersonp @jdknives @mrpalide