Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[M2] Fix default route group timeout #89

Merged
merged 25 commits into from
Jan 15, 2020
Merged

[M2] Fix default route group timeout #89

merged 25 commits into from
Jan 15, 2020

Conversation

Darkren
Copy link
Contributor

@Darkren Darkren commented Dec 25, 2019 •
edited
Loading

Fixes #83

Changes:

  • Close packets are now being propagated between two route groups in a loop
  • Added proper handling of close packets by route group
  • Added correct EOF from the route group's Read

nkryuchkov
nkryuchkov approved these changes Dec 26, 2019
View reviewed changes
Copy link
Contributor

@nkryuchkov nkryuchkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job

go.mod Outdated Show resolved Hide resolved
@Darkren
Copy link
Contributor Author

Darkren commented Jan 9, 2020

Some of the subtests of TestConn for route group are still failing/hanging

@Darkren Darkren changed the title [WIP] [M2] Fix default route group timeout [M2] Fix default route group timeout Jan 9, 2020
nkryuchkov
nkryuchkov approved these changes Jan 13, 2020
View reviewed changes
Copy link
Contributor

@nkryuchkov nkryuchkov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Please don't forget to fix linter errors.

@evanlinjin evanlinjin self-requested a review January 14, 2020 10:08
Kifen
Kifen approved these changes Jan 14, 2020
View reviewed changes
Copy link
Contributor

@Kifen Kifen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

@jdknives jdknives merged commit 5c05605 into skycoin:milestone2 Jan 15, 2020
@jdknives jdknives mentioned this pull request Jan 15, 2020
Closed
@Darkren Darkren deleted the fix/default-route-group-timeout branch February 7, 2020 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kifen Kifen Kifen approved these changes

@nkryuchkov nkryuchkov nkryuchkov approved these changes

@evanlinjin evanlinjin evanlinjin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Darkren @evanlinjin @nkryuchkov @Kifen @jdknives