Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default visor/hypervisor start #90

Merged
merged 7 commits into from
Dec 30, 2019
Merged

Fix default visor/hypervisor start #90

merged 7 commits into from
Dec 30, 2019

Conversation

Darkren
Copy link
Contributor

@Darkren Darkren commented Dec 26, 2019

Fixes #22

Changes:

  • SSH references were removed from Makefile
  • Default config now doesn't have SSH apps
  • Updated vendor to use latest version of DMSG from M2

How to test this PR:

@Darkren
Copy link
Contributor Author

Darkren commented Dec 26, 2019

Hypervisor seems to work. Visor does not. The main problem is that it tries to access the current production DMSG discovery which works for the master branch version, but not for M2. API has changed. There's no point in dancing with the API URLs since the functionality might have been changed too, we're trying to connect two different versions here

@Darkren
Copy link
Contributor Author

Darkren commented Dec 26, 2019

@Senyoret1
Added README files with instructions on how to build and run the DMSG server and discovery locally in here https://github.com/SkycoinPro/skywire-services/pull/40 . In order to run visor, you will need to specify the correct address of your DMSG discovery in the default generated visor config. This is a temporary workaround, I don't see a point in mentioning this in the common skywire README.

The system seems to be running, however hypervisor doesn't see the running visor. There's ongoing work on this, I'll notify on the result

@Darkren
Copy link
Contributor Author

Darkren commented Dec 27, 2019

@Senyoret1 actually it seems to work. Please check it out when you have a minute

@Darkren Darkren changed the title [WIP] Fix default visor/hypervisor start Fix default visor/hypervisor start Dec 27, 2019
@Senyoret1
Copy link
Contributor

I tested the visor and hypervisor and found errors while trying to make the manager UI work with the mainnet-milestone2 brach, which I think was deleted. At this moment I'm not familiar with the changes made to the milestone2, so maybe it won't be of much help if I test this PR, as it will take me some time just to check how things work in that branch (specially for some changes I think were made to the integration with dmsg) and I won't know exactly what to check (some of the issues I filed should not be valid anymore). Maybe it would be better if I take a look when the milestone2 is more mature, to start integrating the manager UI with it. However, if you want me to check it anyways, let me know

@Darkren
Copy link
Contributor Author

Darkren commented Dec 30, 2019

@Senyoret1 if that's the case, I think there's no point for now. I'll get it merged and when m2 gets ready I'll double check that everything works

@Darkren Darkren merged commit 5704b74 into skycoin:milestone2 Dec 30, 2019
@Darkren Darkren deleted the fix/default-visor-hypervisor-start branch December 30, 2019 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants