-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AppStats: Connection Duration Addition to API #908
Conversation
@Senyoret1 can you also try this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good. Functionality is OK and code is clear to me.
I did not check the code, but the functionality appears to be working well. Is the time in seconds? |
it is, is it ok ? |
Yes, seconds is ok for me |
Everything looks good. I just had one suggestion. We should send [
{
"is_alive":true,
"latency":57,
"upload_speed":2283,
"download_speed":411,
"bandwidth_sent":215672,
"bandwidth_received":235619,
"error":""
}
] |
@ersonp done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good and everything is working as intended.
Did you run
make format && make check
? yesFixes #895
Changes:
TODO:
How to test this PR:
vpn-client
app from the visor via UI / cli