Public Autoconnect [API | Summary] #915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ersonp
reviewed
Oct 12, 2021
ersonp
approved these changes
Oct 12, 2021
alexadhy
approved these changes
Oct 12, 2021
jdknives
approved these changes
Oct 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you run
make format && make check? YesFixes #904
Changes:
public_autoconnectfield to/visors/{pk}/summaryendpointPUT /visors/{pk}/public-autoconnectto change value ofpublic_autoconnect. The body of request should be same as{"public_autoconnect":true}.How to test this PR:
public_autoconnectfield.PUTrequest on/visors/{pk}/public-autoconnectendpoint with{"public_autoconnect":true}or{"public_autoconnect":false}to change its value.Note:
As I talked to @jdknives , after this changes we need restart/reboot visor to start connector routine. Maybe after successful change, we should show some alert/notification to user for reboot visor. @Senyoret1