Add stcpr dependency to PublicVisor #922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit commit contains addition to the dependency of the PublicVisor module. StcprClient is added as a dependency.
The commit commit contains fix to the Stcpr() func of the transport manager. It was giving back the client for STCP instead of STCPR and is now been fixed.
ersonp
commented
Oct 12, 2021
pkg/visor/init.go
Outdated
| @@ -133,7 +133,7 @@ func registerModules(logger *logging.MasterLogger) { | |||
| pv = maker("public_visors", initPublicVisors, &tr) | |||
There was a problem hiding this comment.
I think we should rename this module to PublicAutoconnect. @jdknives
The commit renames the initPublicVisors module to initPublicAutoconnect as it is more accurate.
jdknives
approved these changes
Oct 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit commit contains addition to the dependency of the PublicVisor module. StcprClient is added as a dependency.
Did you run
make format && make check?Fixes #
Changes:
How to test this PR: