Fix goreleaser #927
Merged
Fix goreleaser #927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The newly defined build tag was not correctly set in goreleaser.yml -X flag was missing in linker flags. Removed the build tag from applications and skywire-cli as they are not used there and therefore not needed for now.
Excluded .git directory from find command which executes goimports reviser.
alexadhy
approved these changes
Oct 13, 2021
mrpalide
approved these changes
Oct 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you run
make format && make check?Yes
Fixes the goreleaser.yml and the
make formattargetChanges:
-Xflag toskywire-visorbuild flags in goreleaser.ymlfindcommand which executes goimports reviser inmake formatHow to test this PR:
make formatmake snapshotBoth should run.