Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/improve redialing public autoconnect #945

Merged

Conversation

alexadhy
Copy link
Contributor

Did you run make format && make check? yes

Fixes #938

Changes:

  • servicedisc client code already filtered out established transports
  • All I do is added a map of addresses (pks) with attempt(s) as its value, if the attempt to establish transport to the given pk returns an error, then we just record the pk and / or increment the attempt. Currently the maximum number of attempt is just 2, I can change it if it deemed necessary.
  • We only try to establish 3 transport(s) at any given interval.

How to test this PR:

  • Run the skywire-visor with public_autoconnect field in the transport section defined to true
  • See logs

pkg/servicedisc/autoconnect.go Outdated Show resolved Hide resolved
pkg/servicedisc/autoconnect.go Show resolved Hide resolved
@alexadhy alexadhy force-pushed the feature/improve-redialing-public-autoconnect branch from eef2c94 to c5c27f3 Compare October 19, 2021 17:20
@jdknives jdknives merged commit 85a3667 into skycoin:develop Oct 19, 2021
@alexadhy alexadhy deleted the feature/improve-redialing-public-autoconnect branch November 23, 2021 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants