Connect to services over dmsghttp #995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit adds dmsg direct client for communication with services via http over dmsg.
The commit adds dmsgHTTPC to the router that enables the visor to connect to the route-finder via http over dmsg.
The commit adds dmsgHTTPC to the router that enables the visor to connect to the route-finder via http over dmsg.
The commit adds the functionality for the tpdclient to connect to the transport-discovery via http over dmsg. It also contains changes to httpauth to accommodate this functionality.
The commit renames dmsgHTTPC to httpC as it better reflects it's use as it can either be a dmsghttp client or just a http client.
The commit adds the functionality for the utclient to connect to the uptime-tracker via http over dmsg.
The commit adds the functionality for the utclient to connect to the uptime-tracker via http over dmsg.
The commit adds the functionality for the appdisc and servicedisc to connect to the service-discovery via http over dmsg.
The commit adds the functionality for the public autoconnect to connect to the service-discovery via http over dmsg.
The commit adds the functionality for the address-resolver client to connect to the address-resolver via http over dmsg.
The commit changes the var disc to serviceURL and also changes the src string of pushCloseStack in initUptimeTracker to uptime_tracker.
This commit changes the datatype of dmsg servers from []string to []*disc.Entry to better suit it's usage.
This commit adds dmsghttp module moving the older repetative code to one func. It also incudes the func getHTTPClient which further streamlines the code. The service modules address-resolver, discovery, transport, dmsg, router and uptime_tracker are are reliant on the new module. The dClient (dmsg direct client) and dmsgHTTP (dmsghttp client) are added to the Visor struct.
mrpalide
approved these changes
Nov 22, 2021
jdknives
reviewed
Nov 23, 2021
This commit renames the config file localServers.json to dmsghttp-config.json along with it's reference in config gen.
This commit changes the data type of DMSGServers from []string to []*disc.Entry.
jdknives
approved these changes
Nov 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you run
make format && make check?yes
Fixes #985
Changes:
disc.NewHTTPhttp.Clientparam todmsgc.New()initDmsg()to connect to thedmsg-discoveryvia HTTP over dmsg if the URL ofdmsg-discoveryin the config isdmsg://<pk-of-dmsg-discovery>:80dmshhttpmodulelocalServers.jsontodmsghttp-config.jsonDMSGServersfrom[]stringto[]*disc.EntryHow to test this PR:
On test deployment:
On integration env:
Check #skywire-services-486
Needs:
#dmsg-130