Merge pull request #479 from skydoves/refactor/newinstance

Migrate to getDeclaredConstructor from newInstance
skydoves · Aug 28, 2023 · a9c6577 · a9c6577
2 parents 9c97e77 + 4169f25
commit a9c6577
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/balloon/src/main/kotlin/com/skydoves/balloon/internals/ActivityBalloonLazy.kt b/balloon/src/main/kotlin/com/skydoves/balloon/internals/ActivityBalloonLazy.kt
@@ -44,7 +44,7 @@ internal class ActivityBalloonLazy<out T : Balloon.Factory>(
     get() {
       var instance = cached
       if (instance === null) {
-        val factory = factory::java.get().newInstance()
+        val factory = factory::java.get().getDeclaredConstructor().newInstance()
         instance = factory.create(context, lifecycleOwner)
         cached = instance
       }

diff --git a/balloon/src/main/kotlin/com/skydoves/balloon/internals/FragmentBalloonLazy.kt b/balloon/src/main/kotlin/com/skydoves/balloon/internals/FragmentBalloonLazy.kt
@@ -47,7 +47,7 @@ internal class FragmentBalloonLazy<out T : Balloon.Factory>(
         )
       }
 
-      val factory = factory::java.get().newInstance()
+      val factory = factory::java.get().getDeclaredConstructor().newInstance()
       val lifecycle = if (fragment.view !== null) {
         fragment.viewLifecycleOwner
       } else {

diff --git a/balloon/src/main/kotlin/com/skydoves/balloon/internals/ViewBalloonLazy.kt b/balloon/src/main/kotlin/com/skydoves/balloon/internals/ViewBalloonLazy.kt
@@ -46,7 +46,7 @@ internal class ViewBalloonLazy<out T : Balloon.Factory>(
       var instance = cached
       if (instance === null) {
         val context = view.context
-        val factory = factory::java.get().newInstance()
+        val factory = factory::java.get().getDeclaredConstructor().newInstance()
         val viewTreeLifecycle = view.findViewTreeLifecycleOwner()
         when {
           viewTreeLifecycle != null -> {