Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional key into rememberBalloonBuilder #476

Merged

Conversation

egorikftp
Copy link
Contributor

🎯 Goal

Fix issue #475

Preparing a pull request for review (Done)

Ensure your change is properly formatted by running:

$ ./gradlew spotlessApply

Then dump binary APIs of this library that is public in sense of Kotlin visibilities and ensures that the public binary API wasn't changed in a way that makes this change binary incompatible.

./gradlew apiDump

@egorikftp egorikftp requested a review from skydoves as a code owner August 27, 2023 13:56
Copy link
Owner

@skydoves skydoves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you for your contribution.

@skydoves skydoves merged commit d4a112d into skydoves:main Aug 27, 2023
@egorikftp egorikftp deleted the feature/add_key_into_rememberBalloonBuilder branch August 30, 2023 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants