Support detached Fragments by removing references to the Activity

[jimmithy]

🎯 Goal

Previously if we create a fragment that is not yet attached to the activity and reference the balloon, this will throw an IllegalStateException. This is because the lazy loader requires an Activity even thought the implementation only requires Context.

This change removes all references to activities, so the balloon can be successfully attached to the anchor without needing the activity context.

🛠 Implementation details

1. Update Lazy helpers to use requireContext instead of requireActivity
2. Remove unused getActivity method
3. Remove unneccesary Context.isFinishing method because isAttachedToWindow should resolve issue android.view.WindowManager$BadTokenException: Unable to add window -- token null is not valid; is your activity running? #92

Code reviews

All submissions, including submissions by project members, require review. We use GitHub pull requests for this purpose. Consult GitHub Help for more information on using pull requests.

[skydoves]

Hey @jimmithy, checking out the isFinishing is needed for working correctly with Activity. I'm wondering if you can resolve this issue by calling the show method inside the If statements, which has isAttachedToWindow as a condition.

[jimmithy]

Hey @jimmithy, checking out the isFinishing is needed for working correctly with Activity. I'm wondering if you can resolve this issue by calling the show method inside the If statements, which has isAttachedToWindow as a condition.

Hey, I wasn't entirely sure what you were suggesting, but I've restored the isFinishing check in a way that makes the context implementation not necessary.

[skydoves]

Sorry for the very late response. Overall looks good to me. Thank you so much for your contribution 👍