- Added dismiss functionality regarding issue 140 #141
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guidelines
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
This commit is regarding issue 140 that I have already opened, It's a suggested solution to the problem that I mentioned. I already use it in my project with success, so I thought we can add it as an extra helping functionality in PowerSpinner library.
The problem was that in some cases the power spinner stays visible and cannot be dismissed.
My proposed solution is an extension function of the parent view, that iterates all the view hierarchy of the current view,
if we find an instance of PowerSpinner view then dismiss it (with the already dismiss functionality).
The usage is fairly easy -> parentView?.dismissPowerSpinner()
Types of changes
What types of changes does your code introduce?
Preparing a pull request for review
Ensure your change is properly formatted by running:
$ ./gradlew spotlessApply
Please correct any failures before requesting a review.