Reset index when items are changed #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A IndexOutOfBounds exception can occur when setting new items if an item was already selected. Resetting the index was already done in the DefaultSpinnerAdapter but not here.
|
Here you can find the same fix that has already been merged in the DefaultSpinnerAdapter: fd8b99d |
skydoves
approved these changes
Apr 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix (non-breaking change which fixes an issue): #66.
This issue was already resolved but it was only fixed in the DefaultSpinnerAdapter. In this one-line PR the IconSpinnerAdapter has been fixed as well.