Add gradient center color in progressView #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skydoves
reviewed
Jun 25, 2021
Comment on lines
143
to
157
| if (colorGradientCenter == NO_COLOR) { | ||
| GradientDrawable( | ||
| gradientOrientation, | ||
| intArrayOf(colorGradientStart, colorGradientEnd) | ||
| ).apply { | ||
| applyRadius(this) | ||
| } | ||
| } else { | ||
| GradientDrawable( | ||
| gradientOrientation, | ||
| intArrayOf(colorGradientStart, colorGradientCenter, colorGradientEnd) | ||
| ).apply { | ||
| applyRadius(this) | ||
| } | ||
| } |
There was a problem hiding this comment.
How about this way?
GradientDrawable(
gradientOrientation,
intArrayOf(colorGradientStart, colorGradientCenter, colorGradientEnd)
.filter { it != NO_COLOR }.toIntArray()
).apply {
applyRadius(this)
}There was a problem hiding this comment.
Because I want to do like this picture (yellow progress bar), I want add color in gradient center .
There was a problem hiding this comment.
Yes, exactly. So I added colorGradientCenter on the int array and filtered if the color value is NO_COLOR on my suggestion. 😄
There was a problem hiding this comment.
Oh! I understand what you said, right.
So I refactor it.
There was a problem hiding this comment.
Update at commit b7e5050
|
Thanks @Ten-Wang for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guidelines
I have a request need show 3 gradient color on progress
Types of changes
I add a gradient center.
Preparing a pull request for review
Ensure your change is properly formatted by running:
It is the sample