feat(gui): add parameters logging in Frida code snippet (#1497)(PR #1498

)
skylot · May 28, 2022 · fa41874 · fa41874
1 parent 2aa6c99
commit fa41874
Showing 1 changed file with 13 additions and 4 deletions.
diff --git a/jadx-gui/src/main/java/jadx/gui/ui/codearea/FridaAction.java b/jadx-gui/src/main/java/jadx/gui/ui/codearea/FridaAction.java
@@ -92,15 +92,24 @@ private String generateMethodSnippet(JMethod jMth) {
 		} else {
 			functionUntilImplementation = String.format("%s[\"%s\"].implementation", shortClassName, methodName);
 		}
-		String functionParametersString = String.join(", ", collectMethodArgNames(javaMethod));
+
+		List<String> methodArgNames = collectMethodArgNames(javaMethod);
+
+		String functionParametersString = String.join(", ", methodArgNames);
+		String logParametersString =
+				methodArgNames.stream().map(e -> String.format("'%s: ' + %s", e, e)).collect(Collectors.joining(" + ', ' + "));
+		if (logParametersString.length() > 0) {
+			logParametersString = " + ', ' + " + logParametersString;
+		}
 		String functionParameterAndBody = String.format(
-				"%s = function(%s){\n"
-						+ "    console.log('%s is called');\n"
+				"%s = function (%s) {\n"
+						+ "    console.log('%s is called'%s);\n"
 						+ "    let ret = this.%s(%s);\n"
 						+ "    console.log('%s ret value is ' + ret);\n"
 						+ "    return ret;\n"
 						+ "};",
-				functionUntilImplementation, functionParametersString, methodName, methodName, functionParametersString, methodName);
+				functionUntilImplementation, functionParametersString, methodName, logParametersString, methodName,
+				functionParametersString, methodName);
 
 		return generateClassSnippet(jMth.getJParent()) + "\n" + functionParameterAndBody;
 	}