-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core]smali code has these methods, but pseudo code does not have these methods #1170
Comments
@xmhwws looks like these methods was inlined. |
Well, this feature already was reported as issue in #1109, so looks like jadx definitely need some improvement here. Actually it is a big issue in jadx: different people use jadx differently, but I don't want to add switches for every small feature in jadx. That will cause tons of options, and it will be hard to test, reproduce issues and maintain.
|
If these methods disappear due to being inlined, please keep them displayed normally. |
Inlining methods is great for reading and understanding the code, meanwhile people may want to hook such inlined methods and it causes inconvenience. I think we can keep inlining these methods but don't remove them and add an auto-comment at the places they're being inlined. |
Sometime this can be in a complex expression and inserting inplace comment will make it more complex and hard to read. Anyway, as a quick fix I add an option to completely disable methods inline. |
feat: add option to disable methods inline (skylot#1170)
windows10
Latest beta version of jadx
apk link:https://drive.google.com/file/d/1ns6UdqPvwopEFbLIB1e6s_HXoxWR3N_S/view?usp=sharing
class:com.bat.conversation.ui.search.SearchMainActivity
smali code has these methods, but pseudo code does not have these methods
in GDA:
Jadx setting:
The text was updated successfully, but these errors were encountered: