[core] [regression] Compilation error due to code duplication

[nitram84]

I found a regression between jadx-1.2.0-b1486-9744547f (ok, version used java-convert for decompilation) and jadx-1.3.0.213-6e8baef9 (failure with java-convert)
Tested with openjdk8.

Sample:

public class Test1 {

  public Integer calcValue(final Integer i) {
    if (i == null) {
      return null;
    }
    Integer res = null;
    try {
      if (i == 5) {
        res = 4;
      } else {
        res = 9;
      }
    }
    catch (final Exception ex) {
      logError(ex);
    }
    return res;
  }

  private void logError(Exception ex) {
  }
}

This is the decompilation result for jadx-1.3.0.213-6e8baef9 with --use-dx (Thank you for this flag!):

public class Test1 {
    public Integer calcValue(Integer i) {
        Integer res;
        if (i == null) {
            res = null;
            return null;
        }
        res = null;
        try {
            if (i.intValue() == 5) {
                return 4;
            }
            return 9;
        } catch (Exception ex) {
            logError(ex);
            return res;
        }
        logError(ex); // <--- compilation error due to code duplication
        return res;
    }

    private void logError(Exception ex) {
    }
}

Java-input works fine, so this is a dex only issue.

Suggested tags: try-catch, code-duplication, java-convert
Of course this sample can be used in unit tests.

[skylot]

@nitram84 thanks!
Here jadx generate incorrect CFG for try/catch, so it is funny that jadx managed to generate something.
Also, with java-input I also got incorrect code: int res = null; this issue with type inference 🤦

And as a side note: I don't really need info about working version for regressions, I only check latest master branch, so you don't need to find working version :)

[skylot]

Fixed. Type issue was caused by deboxing pass.