Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gui] Log window inconveniences #1311

Closed
CmP-lt opened this issue Dec 20, 2021 · 2 comments
Closed

[gui] Log window inconveniences #1311

CmP-lt opened this issue Dec 20, 2021 · 2 comments
Labels
enhancement GUI Issues in jadx-gui module
Milestone

Comments

@CmP-lt
Copy link
Contributor

CmP-lt commented Dec 20, 2021

Using log window becomes inconvenient when it needs to be opened and closed multiple times because:

  • each time new log window is created;
  • previously opened log windows need to be closed manually to avoid having many log windows that are all brought to foreground when new log window is created;
  • log window gets blocked by main window when the former is sent to background, i.e. need to minimize main window or adjust it's size and/or position to be able to access existing log window.

There would be no such inconveniences if only one log window, that would be brought to foreground when called, could be created.

@skylot
Copy link
Owner

skylot commented Dec 20, 2021

@CmP-lt sure! I agree that it will be nice to:

  1. force only one log window at a time
  2. bring it to front if it opens from menu/toolbar action
  3. convert dialog to window, so it will appear in windows taskbar (like it is done for search dialog)

@skylot skylot added enhancement GUI Issues in jadx-gui module labels Dec 20, 2021
@skylot skylot added this to the TBD milestone Dec 20, 2021
skylot added a commit that referenced this issue Aug 18, 2022
* [gui]: improve log viewer dialog

* use method from UiUtils to set window icons

Co-authored-by: Skylot <skylot@gmail.com>
@skylot
Copy link
Owner

skylot commented Aug 18, 2022

Fixed in PR #1649 by @jpstotz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement GUI Issues in jadx-gui module
Projects
None yet
Development

No branches or pull requests

2 participants