Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Invalid member access expressions #1340

Closed
bagipro opened this issue Jan 18, 2022 · 6 comments
Closed

[core] Invalid member access expressions #1340

bagipro opened this issue Jan 18, 2022 · 6 comments
Labels
bug Core Issues in jadx-core module
Milestone

Comments

@bagipro
Copy link
Collaborator

bagipro commented Jan 18, 2022

Hey!

APK: https://drive.google.com/file/d/1itnzM0TmVY22OFebbD9VHxbpOZ_otZ4k/view?usp=sharing

There are a lot of such issues, but an example is in class androidx.compose.animation.C0427am

    final androidx.compose.animation.core.C0473ba<androidx.compose.animation.EnterExitState>.androidx/compose/animation/core/bb f1744a;

image

@bagipro bagipro added bug Core Issues in jadx-core module labels Jan 18, 2022
@jpstotz
Copy link
Collaborator

jpstotz commented Jan 19, 2022

@bagipro For reproducibility it would better you would add the original class name(s), not the class names generated by deobfuscation as those names seem to be not deterministic so it is difficult to reproduce the state shown in the screen shot.

I am also not sure what you want to point out. Are you referring to the .androidx/compose/animation/core/bb part included in the class name?

@skylot
Copy link
Owner

skylot commented Jan 19, 2022

Are you referring to the .androidx/compose/animation/core/bb part included in the class name?

@jpstotz it is definitely this :)

ba<EnterExitState>.androidx/compose/animation/core/bb

Looks like originally bb class was inner class for ba and use that generic variable from ba.
So jadx needs to detect such signatures and move bb into ba class.

@skylot skylot added this to the TBD milestone Jan 19, 2022
@skylot
Copy link
Owner

skylot commented Jan 22, 2022

@bagipro fixed, please check

@skylot skylot closed this as completed Jan 22, 2022
@bagipro
Copy link
Collaborator Author

bagipro commented Jan 23, 2022

Hey @skylot, sorry for the long response.

I don't think that it's fixed completely. Example in class androidx.compose.animation.core.TransitionKt$createDeferredAnimation$1:

            androidx.compose.animation.core.C0473ba<S>.androidx.compose.animation.core.C0473ba.C0474bb<T, V>.C0475bc<T, V> bcVar = deferredAnimation.f1886a;

the generated name is incorrect androidx.compose.animation.core.C0473ba<S>.androidx.compose.animation.core.C0473ba.C0474bb

Should I reopen the issue?

@skylot
Copy link
Owner

skylot commented Jan 24, 2022

@bagipro sorry, forget to check with full names (with disabled use imports) 😞
Please check latest commit 😁

@bagipro
Copy link
Collaborator Author

bagipro commented Jan 28, 2022

@skylot
Thanks! Yes, that's fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Core Issues in jadx-core module
Projects
None yet
Development

No branches or pull requests

3 participants