Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impossible to set the option "--decompilation-mode" #1434

Closed
boberle opened this issue Apr 4, 2022 · 2 comments
Closed

Impossible to set the option "--decompilation-mode" #1434

boberle opened this issue Apr 4, 2022 · 2 comments

Comments

@boberle
Copy link
Contributor

boberle commented Apr 4, 2022

Throws an exception telling that the values auto, simple, etc. (the ones in the help and readme file) are not valid. Instead, it tells me that possible values are those of another option (--rename-flags).

ERROR - Process error:
java.lang.IllegalArgumentException: 'auto' is unknown for parameter --decompilation-mode, possible values are case, valid, printable
        at jadx.cli.JadxCLIArgs$RenameConverter.convert(JadxCLIArgs.java:470)
        at jadx.cli.JadxCLIArgs$RenameConverter.convert(JadxCLIArgs.java:448)
        at com.beust.jcommander.JCommander.convertValue(JCommander.java:1340)
        at com.beust.jcommander.ParameterDescription.addValue(ParameterDescription.java:249)
        at com.beust.jcommander.JCommander.processFixedArity(JCommander.java:920)
        at com.beust.jcommander.JCommander.processFixedArity(JCommander.java:901)
        at com.beust.jcommander.JCommander.parseValues(JCommander.java:731)
        at com.beust.jcommander.JCommander.parse(JCommander.java:363)
        at com.beust.jcommander.JCommander.parse(JCommander.java:342)
        at jadx.cli.JCommanderWrapper.parse(JCommanderWrapper.java:35)
        at jadx.cli.JadxCLIArgs.processArgs(JadxCLIArgs.java:200)
        at jadx.cli.JadxCLI.execute(JadxCLI.java:35)
        at jadx.cli.JadxCLI.main(JadxCLI.java:20)

Same for options -m and decompilation-mode.

Appears since commit d8306cb.

@boberle
Copy link
Contributor Author

boberle commented Apr 4, 2022

Need to change the file jadx-cli/src/main/java/jadx/cli/JadxCLIArgs.java, line 69, replace:

converter = RenameConverter.class

by:

converter = DecompilationModeConverter.class

@skylot
Copy link
Owner

skylot commented Apr 4, 2022

Fixed in PR #1435 by @boberle 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants