Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Rename exception #1441

Closed
AdminHcat opened this issue Apr 7, 2022 · 2 comments
Closed

[core] Rename exception #1441

AdminHcat opened this issue Apr 7, 2022 · 2 comments
Labels
enhancement GUI Issues in jadx-gui module
Milestone

Comments

@AdminHcat
Copy link

AdminHcat commented Apr 7, 2022

Describe error

  • com.corrodinggames.rts.gameFramework.utility.m
  • 1.15p8.zip

image
image
image
image

@AdminHcat AdminHcat added bug Core Issues in jadx-core module labels Apr 7, 2022
@skylot
Copy link
Owner

skylot commented Apr 7, 2022

@AdminHcat you are trying to rename constructor method, which name should be equal to class name, so looks like jadx just ignore such renames and use class name instead. So... I am not sure how to fix this, possible options are:

  1. forbid constructor rename (just ignore or show warning dialog)
  2. rename class (will also rename constructor)

I think second option is better, but can be confusing if you don't notice it is a constructor and don't want to rename a whole class.

Also, exception you mention is not relevant to this rename, but anyway should be fixed.

@skylot skylot added enhancement GUI Issues in jadx-gui module and removed bug Core Issues in jadx-core module labels Apr 7, 2022
@skylot skylot added this to the TBD milestone Apr 7, 2022
@skylot
Copy link
Owner

skylot commented Apr 10, 2022

Both issues fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement GUI Issues in jadx-gui module
Projects
None yet
Development

No branches or pull requests

2 participants