Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Add "SkipDependencies" argument to not save dependencies to disk #1466

Closed
NASGregorio opened this issue Apr 25, 2022 · 2 comments · Fixed by #1467
Closed

[feature] Add "SkipDependencies" argument to not save dependencies to disk #1466

NASGregorio opened this issue Apr 25, 2022 · 2 comments · Fixed by #1467

Comments

@NASGregorio
Copy link
Contributor

I'm doing research on static analysis of decompiled code, and I'd like to only save the source files that exactly match the class filter.
Right now, when saving, using a filter for "com.foo" for example, the output folder will include the matching files plus dependencies ("com.google", etc)

Something like "setSkipDependencies" and "isSkipDependencies" would do the trick.
I already implemented this change, so if this is useful to others, I can make a PR.

The tool itself has been quite helpful so far. Thanks :)

@skylot
Copy link
Owner

skylot commented Apr 25, 2022

I can make a PR

@NASGregorio this will be very helpful 👍
Actually, this sounds like a bug, class filter intended to output only passed classes without dependencies.
Not sure if someone really needs dependencies after filtering, but having such option is nice anyway 🙂

@NASGregorio
Copy link
Contributor Author

If it is a bug, perhaps make excluding dependencies the default behaviour, and add the option "setIncludeDependencies".
I'll open a PR soon with the changes.

skylot added a commit that referenced this issue Apr 26, 2022
…lter (#1466)(PR #1467)

* feat: Add option to include/exclude dependencies when saving
* fix save skip for class depencencies

Co-authored-by: Skylot <skylot@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants