Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Update variable names after renaming class #1487

Closed
j4k0xb opened this issue May 19, 2022 · 4 comments
Closed

[feature] Update variable names after renaming class #1487

j4k0xb opened this issue May 19, 2022 · 4 comments
Labels
enhancement GUI Issues in jadx-gui module
Milestone

Comments

@j4k0xb
Copy link

j4k0xb commented May 19, 2022

Describe your idea:
When renaming classes, it would be useful if all variables/parameters/etc of that type get their names based on the new instead of original name.

Example (j5 got renamed to Preferences):

Preferences j5Var = this.prefs;

should be shown as preferences or preferencesVar instead of j5Var

Similar thing when hovering, it should show Map<ServerRegion, String> instead:
image

@j4k0xb
Copy link
Author

j4k0xb commented May 21, 2022

Thanks for implementing, already makes it so much easier to look through the code 👍🏻

However I noticed that the tooltip for local variables still shows the original name and null:
image

@skylot
Copy link
Owner

skylot commented May 21, 2022

However I noticed that the tooltip for local variables still shows the original name and null

@j4k0xb sure. This part is a little harder to fix, so I will fix it later.

@skylot skylot added enhancement GUI Issues in jadx-gui module and removed new feature labels May 21, 2022
@skylot skylot added this to the TBD milestone May 21, 2022
@skylot
Copy link
Owner

skylot commented May 23, 2022

@j4k0xb fixed. Please check 😄

@skylot skylot closed this as completed May 23, 2022
@j4k0xb
Copy link
Author

j4k0xb commented May 23, 2022

thx, works as intended now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement GUI Issues in jadx-gui module
Projects
None yet
Development

No branches or pull requests

2 participants