[core][java-input][dx] Warning: Finally extract failed

[nitram84]

This finally-example is different to all other finally issues I reported before. When I try to decompile this sample (compiled with openjdk8) with jadx-1.4.0.8-c906c11b a warning "Finally extract failed" is reported.
Finally extraction fails with java-input or java-convert+dx. Java-convert+d8 works fine without a warning.

This might be a missing corner case for your mark finally algorithm.

public class WarningFinallyExtractFailed {

  private TestClass t;

  public void doSomething() {
    try {
      if(t != null) {
        t.doSomething();
      }
    } finally {
      if(t != null) {
        t.doFinally();
      }
    }
  }

  private class TestClass {

    public void doSomething() {
    }

    public void doFinally() {
    }
  }
}

[skylot]

@nitram84 thanks for a nice test case! I commit a fix to improve blocks tree compare.