Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core]AndroidManifest.xml decode Error #1502

Closed
CKCat opened this issue May 30, 2022 · 2 comments
Closed

[core]AndroidManifest.xml decode Error #1502

CKCat opened this issue May 30, 2022 · 2 comments
Labels
bug Core Issues in jadx-core module

Comments

@CKCat
Copy link
Contributor

CKCat commented May 30, 2022

Some APK AndroidManifest.xml decode Error。Because AndroidManifest.xml the version is 0 。

image

5dfa1dd3d217b330e1812ae926665f31.zip

image

Before
image

After
image
@CKCat CKCat added bug Core Issues in jadx-core module labels May 30, 2022
@skylot
Copy link
Owner

skylot commented May 30, 2022

@CKCat thanks! Sure, this will resolve the issue, and this version check is indeed not really needed.
You can submit a PR if you want 😃

@CKCat CKCat mentioned this issue May 30, 2022
Merged
skylot pushed a commit that referenced this issue May 30, 2022
fix(res): ignore version in AndroidManifest.xml (#1502)(PR #1504)
9d88592
@skylot
Copy link
Owner

skylot commented May 30, 2022

Fixed in PR #1504 by @CKCat 🎉

@skylot skylot closed this as completed May 30, 2022
@anantshri anantshri mentioned this issue May 31, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Core Issues in jadx-core module
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@skylot @CKCat