Resource-only apk is not decoded

[therealchjones]

From 1.3.4 (specifically 54683e3), the addition of

jadx/jadx-cli/src/main/java/jadx/cli/JadxCLI.java

Line 69 in 49137c9

LOG.error("Load failed! No classes for decompile!");

leads to failure to process resource-only apks (e.g., those without java files such as architecture-dependent split apks), even when the --no-src option is given.

In 1.3.3:

% bin/jadx -v -d output/armeabi_v7a config.armeabi_v7a.apk
DEBUG - Effective jadx args: JadxArgs{inputFiles=[config.armeabi_v7a.apk], outDir=output/armeabi_v7a, outDirSrc=output/armeabi_v7a/sources, outDirRes=output/armeabi_v7a/resources, threadsCount=8, cfgOutput=false, rawCFGOutput=false, fallbackMode=false, showInconsistentCode=false, useImports=true, skipResources=false, skipSources=false, deobfuscationOn=false, deobfuscationMapFile=null, deobfuscationMapFileMode=READ, useSourceNameAsClassAlias=false, parseKotlinMetadata=false, useKotlinMethodsForVarNames=APPLY, deobfuscationMinLength=3, deobfuscationMaxLength=64, escapeUnicode=false, replaceConsts=true, respectBytecodeAccModifiers=false, exportAsGradleProject=false, fsCaseSensitive=false, renameFlags=[CASE, VALID, PRINTABLE], outputFormat=JAVA, commentsLevel=INFO, codeCache=NoOpCodeCache, codeWriter=SimpleCodeWriter, useDxInput=false}
INFO  - loading ...
DEBUG - Loading plugin: java-convert
DEBUG - Loading plugin: smali-input
DEBUG - Loading plugin: dex-input
DEBUG - Loading plugin: java-input
DEBUG - Resolved plugins: [dex-input, java-input, smali-input]
DEBUG - Loaded using 0 inputs plugin
INFO  - Loaded classes: 0, methods: 0, instructions: 0
DEBUG - Clst file loaded in 134ms, classes: 4750, methods: 48272
DEBUG - '.arsc' file not found
DEBUG - SignatureProcessor time: 0ms
DEBUG - OverrideMethodVisitor time: 0ms
DEBUG - Deobfuscation map file set to: config.armeabi_v7a.jobf
DEBUG - RenameVisitor time: 2ms
DEBUG - UsageInfoVisitor time: 3ms
DEBUG - ProcessAnonymous time: 0ms
DEBUG - ProcessMethodsForInline time: 0ms
DEBUG - Kotlin Intrinsics class not found
DEBUG - processing threads count: 8
INFO  - processing ...
DEBUG - Build decompilation batches in 2ms
DEBUG - Loaded android attributes count: 158
INFO  - done

In 1.4.1:

% bin/jadx -v -d output/armeabi_v7a config.armeabi_v7a.apk 
DEBUG - Effective jadx args: JadxArgs{inputFiles=[config.armeabi_v7a.apk], outDir=output/armeabi_v7a, outDirSrc=output/armeabi_v7a/sources, outDirRes=output/armeabi_v7a/resources, threadsCount=8, decompilationMode=AUTO, showInconsistentCode=false, useImports=true, skipResources=false, skipSources=false, includeDependencies=false, deobfuscationOn=false, deobfuscationMapFile=null, deobfuscationMapFileMode=READ, useSourceNameAsClassAlias=false, parseKotlinMetadata=false, useKotlinMethodsForVarNames=APPLY, insertDebugLines=false, extractFinally=true, deobfuscationMinLength=3, deobfuscationMaxLength=64, escapeUnicode=false, replaceConsts=true, respectBytecodeAccModifiers=false, exportAsGradleProject=false, fsCaseSensitive=false, renameFlags=[CASE, VALID, PRINTABLE], outputFormat=JAVA, commentsLevel=INFO, codeCache=NoOpCodeCache, codeWriter=SimpleCodeWriter, useDxInput=false, pluginOptions={}, cfgOutput=false, rawCFGOutput=false}
INFO  - loading ...
DEBUG - Loading plugin: java-convert
DEBUG - Loading plugin: smali-input
DEBUG - Loading plugin: dex-input
DEBUG - Loading plugin: java-input
DEBUG - Resolved plugins: [dex-input, java-input, smali-input]
DEBUG - Loaded using 0 inputs plugin in 10 ms
INFO  - Loaded classes: 0, methods: 0, instructions: 0
DEBUG - Clst file loaded in 149ms, classes: 5079, methods: 50746
DEBUG - '.arsc' file not found
DEBUG - SignatureProcessor time: 0ms
DEBUG - OverrideMethodVisitor time: 0ms
DEBUG - Deobfuscation map file set to: /Users/chjones/Downloads/jadx/config.armeabi_v7a.jobf
DEBUG - RenameVisitor time: 2ms
DEBUG - UsageInfoVisitor time: 2ms
DEBUG - ProcessAnonymous time: 0ms
DEBUG - ProcessMethodsForInline time: 0ms
DEBUG - Kotlin Intrinsics class not found
ERROR - Load failed! No classes for decompile!

I'd like a way to at least enable the previous behavior, perhaps when the --no-src option is given, or perhaps offer a warning but not an error when no classes are identified. Happy to work on this if desired.

[skylot]

@therealchjones sorry about such regression 😢

offer a warning but not an error when no classes are identified

I think this is the best way to handle this: log warning and continue, may omit warning if --no-src option is given.
Also, I definitely need a test for this, or I may accidentally break that again.

Happy to work on this if desired.

Sure! PR is welcome.

[therealchjones]

My apologies for the delay. Minutes to change the code, then 2 days to figure out how to create an APK that doesn't have any Java code. 🤦