Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gui] JNodeActions not working when called from context menu #1529

Closed
CmP-lt opened this issue Jun 11, 2022 · 1 comment
Closed

[gui] JNodeActions not working when called from context menu #1529

CmP-lt opened this issue Jun 11, 2022 · 1 comment
Labels
GUI Issues in jadx-gui module regression

Comments

@CmP-lt
Copy link
Contributor

CmP-lt commented Jun 11, 2022

Since 0c3afcc all actions that extend JNodeAction don't work (as if their runAction method doesn't get called, which may be the case) when they are called from context menu, but work normally when called with bound key. This issue doesn't affect actions that extend AbstractAction directly (like CommentAction and CommentSearchAction), they work normally both from context menu and with bound key.

@skylot
Copy link
Owner

skylot commented Jun 11, 2022

@CmP-lt thank you for the tip!
It is weird that method popupMenuWillBecomeInvisible called before actionPerformed. Yeah, docs mention Note that a JPopupMenu can become invisible any time but I didn't think this can be before the reason of menu closing 😕
I commit a fix which don't reset current node in popupMenuWillBecomeInvisible method.
Also looks like this fix resolves a #1514.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GUI Issues in jadx-gui module regression
Projects
None yet
Development

No branches or pull requests

2 participants