Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core]Incomplete search results and white screen for decompiled results #1580

Closed
bhwxha opened this issue Jul 18, 2022 · 6 comments
Closed
Labels
bug Core Issues in jadx-core module regression

Comments

@bhwxha
Copy link

bhwxha commented Jul 18, 2022

link:https://drive.google.com/file/d/1yEzUlBNPa8Jm7H2QozTKfgHM6q47VOuV/view?usp=sharing

A search for tv_value produced only these results:

image

However, in com.yuanrenxue.match2022.adapter.RefreshHeadViewAdapter.OooO0Oo(@NonNull final RecyclerViewHolder recyclerViewHolder, int i, OooO0OO oooO0OO) also exists tv_value, the search results are incomplete.

image

Also, the last result I got from the previous global search for tv_value, when I clicked in, was a white screen.

image

@bhwxha bhwxha added bug Core Issues in jadx-core module labels Jul 18, 2022
@skylot
Copy link
Owner

skylot commented Jul 18, 2022

@bhwxha I can't reproduce this issue with the latest unstable build, maybe it was fixed in #1578. So, please try that build. Although it may be a multithreaded error, did it happen every time?

@bhwxha
Copy link
Author

bhwxha commented Jul 19, 2022

@skylot It's strange, because in my case, the bug has always existed.
I use is the latest jadx, source code version: c27f2ba, download the source code and compile it yourself to use.
I'll upload my jadx zip file here:https://drive.google.com/file/d/1vjURdNV01g-dgB-PxoefVcY0Couw0XDd/view?usp=sharing
jadx decompiled this apk to get the info level logs:https://drive.google.com/file/d/16asu2GRE33gjg9Iom9nPSgGpyODI3LFH/view?usp=sharing
My jadx configuration:https://drive.google.com/file/d/1UNTfeNu50qaCrahEhyb9cCqJGLcH_Wlv/view?usp=sharing

windows11
java -version(Use openjdk8 to compile and use jadx)

openjdk version "1.8.0_322"
OpenJDK Runtime Environment (Temurin)(build 1.8.0_322-b06)
OpenJDK 64-Bit Server VM (Temurin)(build 25.322-b06, mixed mode)

@skylot
Copy link
Owner

skylot commented Jul 19, 2022

@bhwxha thanks for sharing jadx config! Turns out this issue can be reproduced only with Inline anonymous classes option.
I found the cause and committed a fix 👍

@bhwxha
Copy link
Author

bhwxha commented Jul 20, 2022

@skylot Thank you for the fix, the above bug has been solved.

However, I have found suspected new bugs:
Lookup reference to method com.yuanrenxue.match2022.adapter.RefreshHeadViewAdapter.OooO0Oo(@NonNull final RecyclerViewHolder recyclerViewHolder, int i, OooO0OO oooO0OO), the result is 0.

image

jeb:

image

@skylot
Copy link
Owner

skylot commented Jul 20, 2022

@bhwxha I committed a fix, but the actual issue is slightly different.
The method name here is different, because it was inlined/merged with a bridge method, so jadx usage should show usage of that bridge method (I fixed that, also override annotation was missing). So if you want to compare with JEB, I suggest disabling all inline options in preferences (Inline methods for this case), this will show both methods, and it will be easier to compare usages.

@bhwxha
Copy link
Author

bhwxha commented Jul 21, 2022

@bhwxha I committed a fix, but the actual issue is slightly different. The method name here is different, because it was inlined/merged with a bridge method, so jadx usage should show usage of that bridge method (I fixed that, also override annotation was missing). So if you want to compare with JEB, I suggest disabling all inline options in preferences (Inline methods for this case), this will show both methods, and it will be easier to compare usages.

Ok, thanks for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Core Issues in jadx-core module regression
Projects
None yet
Development

No branches or pull requests

2 participants