Fields are not initialized after setContentView [core]

[redmi111]

Fields on the image are supposed to be initialized after setContentView because right now in this way objects are null since they're not initialized properly.

v1.4.3

P.S: Those are global variable and not inside onCreate method and that's the problem (trying to initialize in the field declaration itself)

[skylot]

@redmi111 can you share a sample for this issue? Also share class which contains this code. Without this, it is hard to understand the issue.

[redmi111]

https://we.tl/t-ksKXl4VSeS

Here is the APK and you can find this inside ExitDialog class

[jpstotz]

@redmi111 If you look at the smali code then you will see that the decompiled code is correct, they are initialized in <init>(Landroid/content/Context;)V. So if the code is incorrect this is a bug created by the author of the app. Jadx can only decompile what is present, no matter if it is correct Android code or not.

[redmi111]

Understood, Thanks for the clarification.

[skylot]

As I understand @redmi111 point to the incorrect initialization order and indeed this is an issue here.
I prepare a simple test case:

	StringBuilder sb;
	int field;

	public TestCls() {
		initBuilder(new StringBuilder("sb"));
		this.field = initField();
		this.sb.append(this.field);
	}

	private void initBuilder(StringBuilder sb) {
		this.sb = sb;
	}

	private int initField() {
		return sb.length();
	}

Decompiled code:

    int field = initField();
    StringBuilder sb;

    public TestCls() {
        initBuilder(new StringBuilder("sb"));
        this.sb.append(this.field);
    }
...

Decompiled code throw NPE from initField method because it called before initBuilder.

[skylot]

Fixed.