-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[jadx-gui] Searching for resources while decompilation is in progress causes various thread synchronization problems #1648
Comments
@jpstotz thanks!
|
I commit changes I mention above. Can anyone check it? |
@skylot Thanks for the fix. The search dialog seem to be now safe in 99.99% of all cases. One time I got the following stack trace, but no matter how hard I tried I wasn't able to reproduce it:
After that I only noticed one minor issue in combination with
But as the task is already completed it not really a problem, just printing the strack trace looks like there is a problem. |
@jpstotz thanks for check and feedback!
This is just a warning, indicating that search provider checks cancel state not frequently enough, so it can't stop in time (timeout is very strict). This is a good indicator of bad implementation, so I want to keep it. In last change I made an additional check, so it shouldn't show often 🙂. |
@skylot If you prefer to keep the log message with stack trace as it is, I am also fine with this. Thanks again for the immediate fix - looks like this issue comes it an end... |
The text was updated successfully, but these errors were encountered: