-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Duplicate/Overlapped UI for Logcat pannel when debugging #1752
Comments
Thanks for the bug report I can confirm this issue running on Ubuntu. There are a few other issues with the logcat panel when restarting the debugging session specifically the fact that the process list doesn't currently update dynamically so when an app is restarted it is no longer filtering on the correct pid. In the short term I recommend just closing the debugger panel by clicking on the x button above the logcat panel on the far right below the code display before reattaching the debugger. Ill work on fixing some of the bugs with the logcat panel and polishing it a bit more. |
I did see this as well but I believe that was just the panel staying up/overlapping. At least on windows with my patch it filtered correctly. |
#1761) * Simple fix to duplicate/overlapping logcat windows. Could be improved by not re-creating UI every time * Apply suggestions from code review * Another try to fix trailing spaces using GitHub suggestions Co-authored-by: Zach Snell <zach.snell@bivalogic.com> Co-authored-by: skylot <118523+skylot@users.noreply.github.com>
Created a "fix" though it could be improved. I don't work a lot in Java/Java-UI so was just creating myself a band-aid. Maintainers may want to harden this code to be more efficient with UI creation/reuse/destruction.
Also, would be nice if the PID selection showed the PID of the active filter if only 1 filtered. Just a nice to have if someone does take a deeper look at this.
I did encounter this issue:
Reproduce on Windows 10:
See PR for potential Fix/Band-Aid.
Building, all tests passing, minor change.
The text was updated successfully, but these errors were encountered: