Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate/Overlapped UI for Logcat pannel when debugging #1752

Open
zach-snell opened this issue Jan 9, 2023 · 2 comments
Open

Duplicate/Overlapped UI for Logcat pannel when debugging #1752

zach-snell opened this issue Jan 9, 2023 · 2 comments

Comments

@zach-snell
Copy link
Contributor

zach-snell commented Jan 9, 2023

Created a "fix" though it could be improved. I don't work a lot in Java/Java-UI so was just creating myself a band-aid. Maintainers may want to harden this code to be more efficient with UI creation/reuse/destruction.

Also, would be nice if the PID selection showed the PID of the active filter if only 1 filtered. Just a nice to have if someone does take a deeper look at this.

  • Jadx version: 1.4.5

I did encounter this issue:

  • Release with included Java
  • Release without included Java
  • Locally compiled version

Reproduce on Windows 10:

  • Launch Jadx w/ GUI
  • Start debugging APK
  • Restart debugging APK
  • Change window size / panel shape to cause overlapping panels to reveal
  • Note all panels are still intractable causing much annoyance and the top panel tends to be the oldest panel hiding new debugging content.

See PR for potential Fix/Band-Aid.

Building, all tests passing, minor change.

jadx_fix

@jmlitfi
Copy link
Contributor

jmlitfi commented Jan 11, 2023

Thanks for the bug report I can confirm this issue running on Ubuntu. There are a few other issues with the logcat panel when restarting the debugging session specifically the fact that the process list doesn't currently update dynamically so when an app is restarted it is no longer filtering on the correct pid.

In the short term I recommend just closing the debugger panel by clicking on the x button above the logcat panel on the far right below the code display before reattaching the debugger. Ill work on fixing some of the bugs with the logcat panel and polishing it a bit more.

@zach-snell
Copy link
Contributor Author

Thanks for the bug report I can confirm this issue running on Ubuntu. There are a few other issues with the logcat panel when restarting the debugging session specifically the fact that the process list doesn't currently update dynamically so when an app is restarted it is no longer filtering on the correct pid.

I did see this as well but I believe that was just the panel staying up/overlapping. At least on windows with my patch it filtered correctly.

skylot added a commit that referenced this issue Jan 21, 2023
#1761)

* Simple fix to duplicate/overlapping logcat windows. Could be improved by not re-creating UI every time
* Apply suggestions from code review
* Another try to fix trailing spaces using GitHub suggestions

Co-authored-by: Zach Snell <zach.snell@bivalogic.com>
Co-authored-by: skylot <118523+skylot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants